Simplify module usage by wrapping deferred objects - #117
Open
deric wants to merge 6 commits into
Open
Conversation
deric
changed the title
|
This looks pretty good if it works! |
Author
|
@tskirvin It does work 😃 Just the |
Simplify module usage by a wrapper function.
Instead of
```puppet
$d = Deferred('vault_lookup::lookup', ["secret/test", 'https://vault.hostname:8200'])
```
use
```puppet
$d = vault_lookup::kv('secret/test', 'https://vault.hostname:8200')
```
Deferred sprint evaluation
Author
|
@bastelfreak Could you please have a look at this? Since puppet/openvox 7.x is no longer supported this should work. Is it ok to write Puppet functions? Or should I rewrite it into Ruby API? |
Member
|
Puppet functions are preferred over ruby functions. I will try to take a look later. |
Author
|
@bastelfreak Any particular reason? Performance? or just consistency? Functions have been rewritten into ruby. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify module usage by a wrapper function.
Instead of
use
where appropriate Vault server can be retrieved from Hiera:
the code becomes:
Additionally there's a
vault_lookup::fmt()function for deferred formating: